// ❌ OLD (deprecated - will stop receiving events)
world.on(EventType.PLAYER_DIED, (data: { playerId: string }) => {
  handlePlayerDeath(data.playerId);
});

// ✅ NEW (use ENTITY_DEATH with type filter)
world.on(EventType.ENTITY_DEATH, (data: { 
  entityId: string; 
  entityType: string;
  killedBy?: string;
  deathPosition?: { x: number; y: number; z: number };
}) => {
  if (data.entityType === 'player') {
    handlePlayerDeath(data.entityId);
  }
});

// ❌ OLD
interface DeathLock {
  items?: DeathItemData[];  // Dropped items only
}

// ✅ NEW
interface DeathLock {
  items?: DeathItemData[];      // Dropped items for gravestone
  keptItems?: DeathItemData[];  // OSRS keep-3 items returned on respawn
}

// ❌ OLD (client never synced lootItems)
getNetworkData(): Record<string, unknown> {
  return {
    lootItemCount: this.lootItems.length,
    // lootItems NOT included
  };
}

// ✅ NEW (client syncs lootItems for accurate state)
getNetworkData(): Record<string, unknown> {
  return {
    lootItemCount: this.lootItemCount,
    lootItems: this.lootItems,  // Full items for client sync
  };
}

// Client applies updates via modify()
modify(data: Partial<EntityData>): void {
  super.modify(data);
  if (Array.isArray(changes.lootItems)) {
    this.lootItems = validated.map(item => ({ ...item }));
    this.lootItemCount = this.lootItems.length;
  }
}

import { splitItemsForSafeDeath, ITEMS_KEPT_ON_DEATH } from '@hyperscape/shared';

const { kept, dropped } = splitItemsForSafeDeath(allItems, ITEMS_KEPT_ON_DEATH);
// kept: top 3 most valuable items (returned on respawn)
// dropped: remaining items (go to gravestone)

import {
  sanitizeKilledBy,
  validatePosition,
  isPositionInBounds,
  GRAVESTONE_ID_PREFIX,
} from '@hyperscape/shared';

// Sanitize killer names for display
const safeKiller = sanitizeKilledBy(event.killedBy);

// Validate death position
const validPos = validatePosition(deathPosition);
if (!validPos) {
  // Position invalid (NaN, Infinity)
}

// Check if position is in bounds
if (!isPositionInBounds(position)) {
  // Out of world bounds
}

// Filter gravestone entities
if (entityId.startsWith(GRAVESTONE_ID_PREFIX)) {
  // This is a gravestone, not a player
}

-- Check for active death lock
SELECT * FROM death_locks WHERE player_id = 'player_<id>';

-- Clear stuck death lock
DELETE FROM death_locks WHERE player_id = 'player_<id>';

// ❌ OLD
export const HOME_TELEPORT_CONSTANTS = {
  COOLDOWN_MS: 15 * 60 * 1000,  // 15 minutes
};

// ✅ NEW
export const HOME_TELEPORT_CONSTANTS = {
  COOLDOWN_MS: 30 * 1000,  // 30 seconds
};

// Server sends:
socket.send("homeTeleportFailed", {
  reason: "Home teleport on cooldown (25s remaining)",
  remainingMs: 25000,  // NEW field
});

// Client reads:
import { readHomeTeleportRemainingMs } from '@/game/hud/homeTeleportUi';

const onFailed = (event?: unknown) => {
  const remainingMs = readHomeTeleportRemainingMs(event);
  if (remainingMs > 0) {
    // Enter cooldown state with server-authoritative time
    setState("cooldown");
    setCooldownEndTime(performance.now() + remainingMs);
  }
};

import { formatCooldownRemaining } from '@/server/systems/ServerNetwork/handlers/home-teleport';

formatCooldownRemaining(0);      // "1s" (rounds up)
formatCooldownRemaining(999);    // "1s"
formatCooldownRemaining(60000);  // "1m"
formatCooldownRemaining(90500);  // "1m 31s"

// ❌ OLD (duplicated styling in each panel)
<div className="rounded-lg shadow-2xl border" style={{...getPanelSurfaceStyle(theme)}}>
  <div className="p-3 overflow-y-auto">
    {/* Recipe list */}
  </div>
</div>

// ✅ NEW (use shared components)
import {
  SkillingPanelBody,
  SkillingSection,
  SkillingQuantitySelector,
  getSkillingSelectableStyle,
  getSkillingBadgeStyle,
} from '@/game/panels/skilling/SkillingPanelShared';

<SkillingPanelBody
  theme={theme}
  intro="Browse available recipes..."
  emptyMessage="You don't have the materials to craft anything."
>
  <SkillingSection theme={theme}>
    {/* Recipe list */}
  </SkillingSection>
  
  <SkillingQuantitySelector
    theme={theme}
    showCustomInput={showQuantityInput}
    customQuantity={customQuantity}
    lastCustomQuantity={lastCustomQuantity}
    onCustomQuantityChange={setCustomQuantity}
    onCustomSubmit={handleCustomQuantitySubmit}
    onCancelCustomInput={() => setShowQuantityInput(false)}
    onPresetQuantity={(qty) => handleCraft(selectedRecipe, qty)}
    allQuantity={-1}
    onShowCustomInput={() => setShowQuantityInput(true)}
  />
</SkillingPanelBody>

import { DialogueCharacterPortrait } from '@/game/panels/dialogue/DialogueCharacterPortrait';

<DialogueCharacterPortrait
  world={world}
  npcEntityId={npcEntityId}
  npcName={npcName}
  className="self-start"
/>

import { DialoguePopupShell } from '@/game/panels/dialogue/DialoguePopupShell';

<DialoguePopupShell
  visible={true}
  onClose={closeDialogue}
  title={npcName}
  width={700}
  maxWidth="min(86vw, 700px)"
  maxHeight="min(40vh, 400px)"
>
  <DialoguePanel {...dialogueProps} />
</DialoguePopupShell>

// In useModalPanels.ts:
const handleBankOpen = (data: unknown) => {
  if (d) {
    setBankData({ ...d, visible: true });
    setDialogueData(null);  // NEW: Close dialogue
  }
};

// ❌ OLD (arrow keys always consumed by tabs)
<TabBar
  tabs={tabs}
  activeTab={activeTab}
  onTabChange={setActiveTab}
/>

// ✅ NEW (reserve arrow keys for game controls)
<TabBar
  tabs={tabs}
  activeTab={activeTab}
  onTabChange={setActiveTab}
  reserveArrowKeys={true}  // NEW: Don't consume arrow keys
/>

// ❌ OLD (custom handler for missing packet)
world.on('fletchingComplete', (data) => {
  // Custom handling
});

// ✅ NEW (automatic via ClientNetwork)
// No action required - ClientNetwork forwards to event bus
world.on(EventType.FLETCHING_COMPLETE, (data) => {
  // Handle event
});

ALTER TABLE death_locks ADD COLUMN kept_items JSONB;

-- Remove kept_items column (data loss)
ALTER TABLE death_locks DROP COLUMN IF EXISTS kept_items;

// OLD
COOLDOWN_MS: 15 * 60 * 1000,  // 15 minutes

// NEW
COOLDOWN_MS: 30 * 1000,  // 30 seconds

# OLD
PUBLIC_WS_URL=ws://localhost:5555/ws

# NEW
PUBLIC_WS_URL=ws://localhost:5556/ws

# Rollback to commit before PR #1094
git checkout <commit-before-1094>

-- Remove kept_items column
ALTER TABLE death_locks DROP COLUMN IF EXISTS kept_items;

-- Clear any active death locks (prevents desync)
DELETE FROM death_locks;

bun run build
bun run dev